Repository navigation
fix(native): restore the windows-only taskkill command path - #868
Merged
Merged
Conversation
The remote workspaces change dropped the windowless_async_command import because it looked unused on Linux, but its only caller is the cfg(windows) process tree kill, so alera_native stopped compiling on Windows and the v0.96.0 desktop release failed.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Restored the Windows-only taskkill spawn in terminate_invocation so alera_native compiles after #858 dropped the Linux-unused import.
- Fully qualified
windowless_async_command— the#[cfg(windows)]process-tree kill now callsalera_core::child_process::windowless_async_command("taskkill.exe"), matching other Windows-only call sites and keeping the name out of a file-levelusethat clippy on Linux would strip again.
Grok | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Change
The v0.96.0 release failed twice on
build app windows(runs 36015803627 and 36037904294) withMSB8066 ... alera_native_cargokit ... exited with code -1. Flutter hides cargo's output without-v; a verbose local build shows the real error:#858 removed
use alera_core::child_process::windowless_async_command;fromrust/src/api/process_session.rsbecause it looked unused on Linux, but its only caller is the#[cfg(windows)]process tree kill interminate_invocation. This calls it by its full path so the import cannot go stale on non-Windows hosts again.Validation
flutter build windows --release --dart-define=ALERA_FLAVOR=release -von a Windows 11 machine (Flutter 3.47.2, Rust 1.98.0, Vulkan SDK 1.4.350.0, CI-styleR:\ccargokit scratch dir): failed with the error above before the fix, exits 0 after it.cargo clippy -p alera_native --all-targets -- -D warningson Linux passes.Risk
None beyond the one-line path change. PR CI never compiles
alera_nativefor Windows, so this class of cfg(windows) break only surfaces at release time; a Windowscargo check -p alera_nativeinpr.ymlwould catch it earlier.