Skip to content

fix(native): restore the windows-only taskkill command path - #868

Merged
leynier merged 1 commit into
mainfrom
fix/windows-build-failure
Sep 25, 2026
Merged

leynier merged 1 commit into
mainfrom
fix/windows-build-failure

Conversation

@leynier

@leynier leynier commented Sep 24, 2026 •

Copy link
Copy Markdown
Owner

Change

The v0.96.0 release failed twice on build app windows (runs 36015803627 and 36037904294) with MSB8066 ... alera_native_cargokit ... exited with code -1. Flutter hides cargo's output without -v; a verbose local build shows the real error:

error[E0425]: cannot find function `windowless_async_command` in this scope
  --> src\api\process_session.rs:273:27

#858 removed use alera_core::child_process::windowless_async_command; from rust/src/api/process_session.rs because it looked unused on Linux, but its only caller is the #[cfg(windows)] process tree kill in terminate_invocation. This calls it by its full path so the import cannot go stale on non-Windows hosts again.

Validation

  • flutter build windows --release --dart-define=ALERA_FLAVOR=release -v on a Windows 11 machine (Flutter 3.47.2, Rust 1.98.0, Vulkan SDK 1.4.350.0, CI-style R:\c cargokit scratch dir): failed with the error above before the fix, exits 0 after it.
  • cargo clippy -p alera_native --all-targets -- -D warnings on Linux passes.

Risk

None beyond the one-line path change. PR CI never compiles alera_native for Windows, so this class of cfg(windows) break only surfaces at release time; a Windows cargo check -p alera_native in pr.yml would catch it earlier.

The remote workspaces change dropped the windowless_async_command import
because it looked unused on Linux, but its only caller is the cfg(windows)
process tree kill, so alera_native stopped compiling on Windows and the
v0.96.0 desktop release failed.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

Restored the Windows-only taskkill spawn in terminate_invocation so alera_native compiles after #858 dropped the Linux-unused import.

  • Fully qualified windowless_async_command — the #[cfg(windows)] process-tree kill now calls alera_core::child_process::windowless_async_command("taskkill.exe"), matching other Windows-only call sites and keeping the name out of a file-level use that clippy on Linux would strip again.

Pullfrog  | View workflow run | Using Grok | 𝕏

@leynier
leynier merged commit 968f7cb into main Sep 25, 2026
20 checks passed
@leynier
leynier deleted the fix/windows-build-failure branch September 25, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant