Repository navigation
feat(workbench): add home button to workspace sidebar - #907
Merged
Merged
Conversation
- Return to the welcome dashboard without closing workspace tabs - Keep home and collapse actions pinned to the expanded sidebar edge - Add controller, widget, and layout coverage for home navigation
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ℹ️ No critical issues. Two rough edges worth a look.
Reviewed changes
One commit adds a sidebar Home control that returns to the welcome dashboard without closing the active workspace.
- Home button. The expanded sidebar header shows a Home icon button wired to
WorkbenchController.showHome. - Selection.
showHomenullsactiveWorkspaceId, keeps the project and tabs, and no-ops when already home, so the shell's existing null-workspace path showsWelcomeDashboard. - Header layout. The brand group is an
Expandedrow so Home and collapse stay on the right edge instead of sharing slack with aSpacer. - Tests. Controller preservation and the no-op, header alignment, collapsed hiding, and worktree-role finders scoped off the shared house glyph.
grok-4.7 ｜ 𝕏
- Use the dashboard glyph for Home; the house already marks the main worktree row - Leaving a workspace for Home or a project puts it on the back stack, so Go Back returns to it - Re-selecting the workspace just left does not stack it twice - Selections and back/forward overtaken by Home no longer record history
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
The follow-up commit fixes the two notes from the previous review: Home no longer shares the main-worktree glyph, and leaving a workspace updates worktree history so Go Back returns to it.
- Left worktree history.
leaveCurrentpushes the current target onto the back stack, clears forward, and nulls the cursor.showHomeandactivateProjectboth call it. - Avoided a duplicate entry. Selecting the workspace just left pops that back entry instead of stacking it again.
- Ignored a superseded selection. A selection records history only while that workspace is still active, and
goBack/goForwardskip their commit if Home replaced the target during the await. - Split the glyphs. Home uses
LucideIcons.layoutDashboard, so it no longer compares equal to the main-worktree house icon.
grok-4.7 ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
showHome()to clear the active workspace while preserving its tabs and session state.Why
Users can now return to the welcome dashboard without closing their active workspace. Reopening the workspace preserves its existing tabs and state for a seamless return.