Repository navigation
fix: apply the mobile allowlist to orchestration requests - #909
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the orchestration mobile allowlist gate against the early dispatch path, the allowlist, and the new dispatcher tests.
- Allowlist on the early router —
handle_orchestration_requestnow callsrequire_authenticated_local_requestbefore any verb runs, so a paired phone or relay client is refused unless that exact verb is on the mobile allowlist. - Dispatcher tests — Local, phone, relay, and unauthenticated clients drive
handle_line. A phoneorchestration.resetis refused and does not clear a message a local client already sent.
grok-4.7 | 𝕏
leynier
force-pushed
the
fix/orchestration-mobile-allowlist
branch
from
October 6, 2026 16:17
bc65340 to
02d985d
Compare
leynier
added this pull request to stack #919
October 6, 2026 16:17
leynier
force-pushed
the
fix/orchestration-mobile-allowlist
branch
from
October 6, 2026 18:14
02d985d to
b58dbf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
orchestration.*requests were routed inclient_request_dispatch.rsbeforehandle_request, so the only check they got wasrequire_auth. An authenticated paired phone or relay client could therefore call every orchestration verb (reset, cancel, policy approval, send, reply, inbox reads), even thoughmobile_request_allowedlists none of them. The orchestration router now callsrequire_authenticated_local_request, so non-local clients get the same "Mobile clients cannot call terminal host request" refusal as every other verb outside the allowlist. Local clients (desktop app, CLI, hub self-client) are unchanged.This is the first PR of the inbox stack: the inbox verbs added later are reachable from the phone only through explicit allowlist entries.
Validation
orchestration_mobile_access_testsdrive the real dispatcher (handle_line) with local, paired mobile, relay and unauthenticated clients. With the fix reverted, the phone could runorchestration.resetand both tests failed; with the fix they pass.cargo clippy -p alera-cli --all-targets -- -D warningsandcargo test -p alera-cli(1847 unit tests plus integration tests) pass locally.dart run tool/quality/check_max_lines.dartpasses.Risk
A mobile build that relied on calling
orchestration.*directly would now be refused; the mobile app does not call any orchestration verb today.