Repository navigation
fix: patch rustls and sharp security advisories - #922
Merged
Merged
Conversation
Bump transitive rustls to 0.23.45 in the desktop and cloud lockfiles, and landing sharp to 0.35.5.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the lockfile security bumps in 7ae9c061.
- rustls 0.23.45:
cloud/Cargo.lockandrust/Cargo.lockeach move the onlyrustlspin from 0.23.43 to 0.23.45, the patched release for GHSA-2mjx-qc3c-rqvc. The published checksum matches, and the tightenedrustls-webpkiandaws-lc-rsfloors are already satisfied by the locked versions. - sharp 0.35.5:
landing/package.jsonandlanding/bun.lockmove the direct devDependency and its bundled@img/sharp-libvips-*1.3.4 packages to the GHSA-wq5f-xc86-pv6w patched release, which ships librsvg 2.63.2. The npm integrity matches the published package.
grok-4.7 | 𝕏
A concurrent stale reclaim can return 503 while the other request still holds the claim. Count one successful delivery and treat 503 as valid, matching the earlier duplicate race.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed the contract-test change in 95f9f733 since the prior review of 7ae9c061.
- Accepted in-progress on stale reclaim: The concurrent stale-pending reclaim now allows
503when the loser observes the winner's fresh claim, instead of requiring both posts to return200. - Kept the one-delivery invariant:
concurrent_duplicate_deliveriesstill requires successful responses to be duplicates, queued deliveries to sum to 1, and the send counter to move by exactly one.
grok-4.7 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
rustlsfrom 0.23.43 to 0.23.45 inrust/Cargo.lockandcloud/Cargo.lock(GHSA-2mjx-qc3c-rqvc).sharpfrom 0.35.4 to 0.35.5, including its bundled libvips binaries (GHSA-wq5f-xc86-pv6w). The installed build reports librsvg 2.63.2.Dependabot alerts 1-3 were already fixed. No documentation update: this does not change runtime behavior or contributor workflow.
Validation
cargo metadata --lockedforrust/Cargo.tomlandcloud/Cargo.tomlwith Rust 1.98.0 resolvesrustls0.23.45.bun testinlanding/(103 pass) andbun run build.sharp0.35.5 reportsrsvg2.63.2.Risks
sharpis a landing devDependency used to render demo media. The site build does not decode untrusted SVG.