Repository navigation
ci: run independent workflow steps in parallel - #923
Merged
Merged
Conversation
Uses the GitHub Actions parallel and background step keywords to overlap steps that share nothing: the desktop-build workflow tests with the app build (private cargo target dirs so they never take the build's lock), the cloud container build with the cargo checks and with the production state reads, apt and Playwright installs with the Flutter or Bun setup, the release downloads with the publish setup, and the Windows tuning with the cache restores so the Defender exclusions apply to them.
Contributor
There was a problem hiding this comment.
ℹ️ One overlap miss on Linux and macOS. The rest matches the
background/wait-allrules, and the jobs that already ran on this branch succeeded.
Reviewed changes
Reviewed the parallel-step conversion across the PR, desktop, release, cloud, landing, warm-cache, and Windows PTY workflows, plus the contract tests that pin ordering and cargo target dirs.
- Desktop build overlap. Workflow cargo tests run beside
flutter build, with await-allbefore the native timing suites. Windows tuning starts before setup so Ninja andALERA_CARGOKIT_TEMP_DIRapply at the wait. - PR Checks. Static, package, generation, and mobile steps that do not share a package resolution now run together, with
--no-pubafter one resolve and ALSA waited on before mobile tests. - Release cut. Archives, artifact uploads, publish-time downloads, and draft uploads plus attestations overlap. Conditional background steps use
wait-all. - Cloud and landing. The backend image build overlaps cargo checks, deploy pushes the image while state is read, infra checks run side by side, and Playwright installs during the landing unit tests and build.
grok-4.7 | 𝕏
Desktop Builds run 37696090551 overlapped them with flutter build: the build doubled on every platform and the debug integration builds lost the rust/target dependencies those suites leave behind, so each leg got slower.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Reviewed 450e31ea, which puts the desktop-build workflow cargo tests back in the foreground after run 37696090551 showed the overlap was a net loss.
- Foreground workflow tests. Restored the three desktop-build cargo suites to sequential steps ahead of
flutter build, matchingmain, so later debug integration builds still see the artifacts those suites leave inrust/target. - Regression guard. Asserted those steps are not
background, and recorded the measured slowdown in.github/AGENTS.md.
grok-4.7 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Uses the new GitHub Actions
parallel/background/wait/wait-allstep keywords to overlap steps that share nothing. Composite actions cannot declare them, so all the overlap lives in the workflows. Estimates come from step timings of recent runs (PR Checks 37542513947, Cut Release 37544847437, Cloud Deploy 37571177618, Desktop Builds 36038731698).backenddocker buildin the background during fmt/clippy/testdeploymobilegenerationstatic,packagesinfrastructuretune-windows-buildin the background before the setup, so the Defender exclusions are in place while the Flutter and pub caches are restoredTried and reverted: running the desktop-build workflow
cargo testsuites in the background besideflutter build(run 37696090551). The build doubled on every platform and the debug integration builds lost the sharedrust/targetdependencies (Linux 33 → 46 min, macOS 64 → 78 min). A contract test now keeps them in the foreground.Not changed: rust test/clippy (one composite step, and the PTY suites flake under concurrency), PR test shards (setup then test), iOS device ‖ simulator builds (they share
Generated.xcconfig), mobile-build Android, Windows PTY tests (the same target dir serializes them)..github/AGENTS.mddocuments the rules: wait before reading a background step's env/outputs, preferwait-allfor conditional steps,--no-pubinside groups, one target dir per background cargo invocation, no overlap of builds/native suites.Validation
--no-pub. Each fails when its change is reverted.git diff --check, analyze.dry_rundispatch, which parses release-cut.yml and only plans. On the Desktop Builds dispatch, Linux and macOS passed. Windows failed in a later debugcmake_install(INSTALL.vcxproj, MSB3073) after the background steps had finished, and the two previous dispatches also failed onbuild windows.Risks