Rename "inclusive groups" to "additive groups"#15
Open
lfbittencourt wants to merge 1 commit intomainfrom
Open
Conversation
Renames the concept throughout: variable isIgroup → isAdditiveGroup in parser.ts, test file igroups.spec.ts → agroups.spec.ts with updated describe/it labels, and README section heading and prose updated to use the new term. Closes #14 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR renames "inclusive groups" to "additive groups" throughout the codebase to improve clarity and reduce confusion. The term "inclusive groups" was misleading because it suggested wrong connotations (DE&I) and set incorrect expectations about the feature's behavior with 3+ options. The new name "additive groups" better describes the mechanism (a combined option is added) and aligns with the + syntax.
Changes:
- Renamed variable
isIgrouptoisAdditiveGroupin the parser - Renamed test file from
igroups.spec.tstoagroups.spec.tsand updated all test descriptions - Updated README documentation to use "additive groups" terminology with improved clarity
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/parser.ts | Renamed isIgroup variable to isAdditiveGroup for consistency with new terminology |
| tests/expand/agroups.spec.ts | Renamed test file and updated all describe/it labels from "igroups"/"inclusive groups" to "additive groups" |
| README.md | Updated section heading and prose to use "additive groups" with clearer explanation of the feature's behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isIgroup→isAdditiveGroupinsrc/parser.tstests/expand/igroups.spec.ts→agroups.spec.tsand updates alldescribe/itlabelsCloses #14
Test plan
yarn test)🤖 Generated with Claude Code