Skip to content

Conversation

@vvalderrv
Copy link
Contributor

Update syntax to enable resolution

Update syntax to enable resolution

Signed-off-by: Vanessa Valderrama <[email protected]>
@vvalderrv vvalderrv requested a review from Copilot September 24, 2025 23:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates SSH key configuration syntax in Jenkins values files to enable proper resolution of 1Password secret references by wrapping them in variable expansion syntax.

  • Removes deprecated sshKeysCredentialsId configuration from amazonEC2 cloud settings
  • Updates privateKey values to use ${...} syntax for proper variable expansion of 1Password references

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
staging/values.yaml Removes sshKeysCredentialsId and updates privateKey syntax with variable expansion
production/values.yaml Removes sshKeysCredentialsId and updates privateKey syntax with variable expansion

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vvalderrv vvalderrv merged commit 88e791a into lfit:main Sep 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant