Skip to content

Conversation

@vvalderrv
Copy link
Contributor

Removed wrapper from values files

Validation:

  • YAML
  • Helm rendering
  • Chart dependency

Removed wrapper from values files

Validation:
 - YAML
 - Helm rendering
 - Chart dependency

Signed-off-by: Vanessa Valderrama <[email protected]>
@vvalderrv vvalderrv requested a review from Copilot September 25, 2025 19:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes shell-style variable expansion syntax from 1Password credential references in Helm values files. The change updates the 1Password secret reference format from "${op://...}" to "op://..." across staging and production environments.

  • Simplified 1Password credential reference syntax by removing ${} wrapper
  • Updated both staging and production values.yaml files consistently

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
staging/values.yaml Removed ${} wrapper from 1Password private key reference
production/values.yaml Removed ${} wrapper from 1Password private key reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vvalderrv vvalderrv merged commit 76f8192 into lfit:main Sep 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant