examples/c: add bootstrap_legacy for compatibility with older kernels #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linrl3
force-pushed
the
bootstrap-legacy
branch
4 times, most recently
from
ed28460 to
f88fabb
Compare
|
@anakryiko Please take a look, thanks. |
anakryiko
requested changes
Oct 13, 2025
examples/c/bootstrap_legacy.bpf.c
Outdated
| { | ||
| struct task_struct *task; | ||
| unsigned fname_off; | ||
| struct event *e = &(struct event){}; |
There was a problem hiding this comment.
I'm actually unsure what exactly does this do. Will it point e to a shared piece of memory, or each function call will get it's own copy?
Let's keep it simple and have explicit:
struct event e = {};
...
e.exit_event = false;
...
?
There was a problem hiding this comment.
sure, I made a change to it.
examples/c/bootstrap_legacy.bpf.c
Outdated
| __uint(type, BPF_MAP_TYPE_PERF_EVENT_ARRAY); | ||
| __uint(key_size, sizeof(u32)); | ||
| __uint(value_size, sizeof(u32)); | ||
| } pe SEC(".maps"); |
There was a problem hiding this comment.
renamed it to "perf_buffer" to make it clear
examples/c/bootstrap_legacy.bpf.c
Outdated
| int handle_exit(struct trace_event_raw_sched_process_template *ctx) | ||
| { | ||
| struct task_struct *task; | ||
| struct event *e = &(struct event){}; |
There was a problem hiding this comment.
same here, please keep it simple
Signed-off-by: Runlong Lin <[email protected]>
linrl3
force-pushed
the
bootstrap-legacy
branch
from
f88fabb to
ea8d284
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to solve #349.
I tested in kernel 5.4 and it works good.
$ cd examples/c $ make bootstrap_legacy $ sudo ./bootstrap_legacy TIME EVENT COMM PID PPID FILENAME/EXIT CODE 10:26:32 EXEC sh 4101543 4054526 /bin/sh 10:26:32 EXEC python 4101545 4101543 /usr/bin/python 10:26:32 EXIT python 4101545 4101543 [0] (9ms) 10:26:32 EXIT sh 4101543 4054526 [0] (10ms)