Add state and handle cleanup in NetStream.{reset|close} #528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The NetStream class was too simple to clean up resources in SwarmConn and to trigger the ClosedStream event in the notifee. There was no state management in NetStream to handle actions for reset/close.
Issue #300: Add state and handle cleanup in NetStream.{reset|close}
How was it fixed?
Added StreamState enum to manage different states of the stream.
Updated the NetStream class to include state management.
Implemented state handling in reset and close methods.
Added a remove method to handle cleanup and trigger the ClosedStream event.
Changes made:
libp2p/network/stream/net_stream.py:
Added StreamState enum.
Updated NetStream class to include state management.
Modified reset and close methods to handle state changes.
Added remove method for cleanup.
To-Do
Cute Animal Picture