-
Notifications
You must be signed in to change notification settings - Fork 183
Update Crypto Dependencies #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: varun-r-mallya <[email protected]>
87ef8c1
to
966cef5
Compare
@varun-r-mallya : Nice effort indeed. Please resolve merge conflicts. Wish to share that you might have to re-base your branch, which would help resolve the merge conflicts. |
@varun-r-mallya are you bumping these due a specific feature or bug in these libraries? Generally it is best practice to keep the accepted versions as open as possible to avoid dependency problems with other libraries. |
@pacrob : Thank you Paul for sharing the feedback. Appreciate it. @varun-r-mallya : Yes, Varun. Please elaborate the pull request description and the issue. Kindly share feedback on Paul's pointers. |
I mostly did it back then to solve the issue that was created, which I figured was just a version bumping chore. I think the motivation is explained in the issue itself, but yes, I certainly do agree with you on keeping the crypto dependencies slightly out of date. |
@pacrob : Not sure, if @varun-r-mallya is working on this PR at this juncture. @varun-r-mallya : Please confirm if you are working on it. Luca asked about the status of this and some other PRs in a recent meeting. |
I think the PR is not useful at this moment, so it’s better to close it. But, once these versions mature, we could bump them up. I hope the corresponding issue will be closed as well. |
@varun-r-mallya : I'll ask new contributors to join in and contribute. Will keep both the PR and issue open. We are looking for a good number of easy to-do issues so that the new contributors can come to speed happily. |
What was wrong?
Issue #654
How was it fixed?
Just changed the versions to latest
To-Do