Skip to content

Conversation

varun-r-mallya
Copy link
Contributor

@varun-r-mallya varun-r-mallya commented Jul 1, 2025

What was wrong?

Issue #654

How was it fixed?

Just changed the versions to latest

To-Do

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

@seetadev
Copy link
Contributor

seetadev commented Jul 3, 2025

@varun-r-mallya : Nice effort indeed. Please resolve merge conflicts.

Wish to share that you might have to re-base your branch, which would help resolve the merge conflicts.

@pacrob
Copy link
Member

pacrob commented Jul 11, 2025

@varun-r-mallya are you bumping these due a specific feature or bug in these libraries?

Generally it is best practice to keep the accepted versions as open as possible to avoid dependency problems with other libraries.

@seetadev
Copy link
Contributor

@pacrob : Thank you Paul for sharing the feedback. Appreciate it.

@varun-r-mallya : Yes, Varun. Please elaborate the pull request description and the issue. Kindly share feedback on Paul's pointers.

@varun-r-mallya
Copy link
Contributor Author

varun-r-mallya commented Aug 10, 2025

@varun-r-mallya are you bumping these due a specific feature or bug in these libraries?

Generally it is best practice to keep the accepted versions as open as possible to avoid dependency problems with other libraries.

@pacrob

I mostly did it back then to solve the issue that was created, which I figured was just a version bumping chore. I think the motivation is explained in the issue itself, but yes, I certainly do agree with you on keeping the crypto dependencies slightly out of date.

@seetadev
Copy link
Contributor

@pacrob : Not sure, if @varun-r-mallya is working on this PR at this juncture.

@varun-r-mallya : Please confirm if you are working on it. Luca asked about the status of this and some other PRs in a recent meeting.

@varun-r-mallya
Copy link
Contributor Author

@pacrob : Not sure, if @varun-r-mallya is working on this PR at this juncture.

@varun-r-mallya : Please confirm if you are working on it. Luca asked about the status of this and some other PRs in a recent meeting.

I think the PR is not useful at this moment, so it’s better to close it. But, once these versions mature, we could bump them up. I hope the corresponding issue will be closed as well.

@seetadev
Copy link
Contributor

@varun-r-mallya : I'll ask new contributors to join in and contribute. Will keep both the PR and issue open.

We are looking for a good number of easy to-do issues so that the new contributors can come to speed happily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants