Skip to content

Conversation

acul71
Copy link
Contributor

@acul71 acul71 commented Jul 13, 2025

Fixed invalid CID with a valid one in test.
Fixed typecheck issue

image

@acul71
Copy link
Contributor Author

acul71 commented Jul 13, 2025

@seetadev Ready to be merged

@seetadev
Copy link
Contributor

@acul71 : Thank you so much for your great efforts. Appreciate it.

Please add the newsfragment. I'll merge it.

@seetadev seetadev self-requested a review July 14, 2025 20:26
@seetadev
Copy link
Contributor

@acul71 : Please include tests to validate fix too. Recommended by Paul for important PRs like the one shared.

@acul71
Copy link
Contributor Author

acul71 commented Jul 15, 2025

Please include tests to validate fix too. Recommended by Paul for important PRs like the one shared.

What you mean?
This fix was a test fix.
Let me know, Ciao

If you're make a reference to typecheck fix with cast:

Does cast() Need a Test?

No. The cast() function is used only for type checking and has no effect at runtime. It does not require its own test.

✅ Your existing test test_info_from_p2p_addr_valid() already exercises the casted code path.

@acul71
Copy link
Contributor Author

acul71 commented Jul 15, 2025

@seetadev
Merging this make possible merge
feat: add py-multiaddr from git #766
(merging main)

@seetadev
Copy link
Contributor

@acul71 : Great, thank you for your feedback, Luca. Appreciate it.

@seetadev seetadev merged commit 719246c into libp2p:main Jul 15, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants