fix: GossipSub peer propagation to include FloodSub peers #893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When a node publishes a message immediately after connecting to a peer, py-libp2p sometimes crashes with:
This happens in pubsub/gossipsub.py, where
self.peer_protocol[peer_id
] is accessed before the identify handshake has finished. The handshake is asynchronous, so peer_protocol may not yet contain the connected peer.Issue #887
How was it fixed?
peer_protocol
Summary of approach.
To-Do
Cute Animal Picture