Skip to content

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Mar 29, 2023

Description

Depends-On: #3693.

Notes & open questions

Unblocks @melekes. See #3652 (comment)

Targets master. I will fast forward v0.51 branch once this pull request is merged and release from v0.51.

I would like to include #3693 first.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden mxinden requested a review from thomaseizinger March 29, 2023 07:15
@mxinden mxinden mentioned this pull request Mar 29, 2023
4 tasks
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 486ac8b into libp2p:master Mar 29, 2023
@mxinden
Copy link
Member Author

mxinden commented Mar 29, 2023

Published and tagged the following crates:

  • autonat-example-v0.1.0
  • libp2p-allow-block-list-v0.1.0
  • libp2p-connection-limits-v0.1.0
  • libp2p-gossipsub-v0.44.2
  • libp2p-mdns-v0.43.1
  • libp2p-perf-v0.1.0
  • libp2p-swarm-v0.42.1
  • libp2p-v0.51.2
  • libp2p-webrtc-v0.4.0-alpha.4
  • relay-server-example-v0.1.0

@mxinden
Copy link
Member Author

mxinden commented Mar 29, 2023

@thomaseizinger meta level, as before, super easy to cut a round of patch releases now.

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Mar 29, 2023

  • autonat-example-v0.1.0
  • relay-server-example-v0.1.0

Why did we publish these two examples? I always thought of these as crates that we would just have in our workspace but not actually push to crates.io.

@mxinden
Copy link
Member Author

mxinden commented Mar 29, 2023

Ah, sorry, confusing comment.

The examples are not published, only tagged.

https://crates.io/crates/autonat-example gives a 404.

cargo release tags them despite publish = false. I didn't bother excluding them from the cargo release tag. Do you feel strongly about excluding them?

@thomaseizinger
Copy link
Contributor

Not at all, I just don't want them published 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants