feat(webrtc): increase max message size to 256kiB #5589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumemichel
force-pushed
the
webrtc-message-size
branch
from
2f83730 to
c8eff60
Compare
guillaumemichel
force-pushed
the
webrtc-message-size
branch
from
6889cb0 to
094c764
Compare
dariusc93
approved these changes
Sep 5, 2024
Member
dariusc93
left a comment
dariusc93
left a comment
There was a problem hiding this comment.
LGTM.
Should we make this a draft until the spec has been updated to prevent this from being merged by mistake?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increasing WebRTC max message size from 16 kiB to 256 kiB after fix browser bugs.
Context: libp2p/specs#628
Notes & open questions
To be merged after libp2p/specs#628 is merged.
Change checklist