Skip to content

fix(webrtc): turn down the webrtc log spam #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(webrtc): turn down the webrtc log spam #5966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d486b0c
turn down the webrtc log spam
Mar 31, 2025
d6bdd70
changelog update
Mar 31, 2025
d3afa0a
Merge branch 'master' into fix-turn-down-webrtc-spam
jxs Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions transports/webrtc/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
## 0.9.0-alpha

<!-- Update to libp2p-core v0.43.0 -->
- Turn down the log spam slightly.
See [PR 5966](https://github.com/libp2p/rust-libp2p/pull/5966)

## 0.8.0-alpha

Expand Down
4 changes: 2 additions & 2 deletions transports/webrtc/src/tokio/connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ impl Connection {
Ok(detached) => {
let mut tx = tx.lock().await;
if let Err(e) = tx.try_send(detached.clone()) {
tracing::error!(channel=%id, "Can't send data channel: {}", e);
tracing::warn!(channel=%id, "Can't send data channel: {}", e);
// We're not accepting data channels fast enough =>
// close this channel.
//
Expand Down Expand Up @@ -286,7 +286,7 @@ pub(crate) async fn register_data_channel_open_handler(
match data_channel.detach().await {
Ok(detached) => {
if let Err(e) = data_channel_tx.send(detached.clone()) {
tracing::error!(channel=%id, "Can't send data channel: {:?}", e);
tracing::warn!(channel=%id, "Can't send data channel: {:?}", e);
if let Err(e) = detached.close().await {
tracing::error!(channel=%id, "Failed to close data channel: {}", e);
}
Expand Down
Loading