Skip to content

fix: add Gossipsub protocol to ALLOWED_PROTOCOLS in identify metrics #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add Gossipsub protocol to ALLOWED_PROTOCOLS in identify metrics #5992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions misc/metrics/src/identify.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
// DEALINGS IN THE SOFTWARE.

#[cfg(feature = "gossipsub")]
use libp2p_gossipsub::GOSSIPSUB_PROTOCOL_ID;

Check failure on line 22 in misc/metrics/src/identify.rs

View workflow job for this annotation

GitHub Actions / Compile on wasm32-unknown-emscripten 

unresolved import `libp2p_gossipsub::GOSSIPSUB_PROTOCOL_ID`

Check failure on line 22 in misc/metrics/src/identify.rs

View workflow job for this annotation

GitHub Actions / Compile on wasm32-unknown-unknown 

unresolved import `libp2p_gossipsub::GOSSIPSUB_PROTOCOL_ID`

Check failure on line 22 in misc/metrics/src/identify.rs

View workflow job for this annotation

GitHub Actions / Compile on wasm32-wasip1 

unresolved import `libp2p_gossipsub::GOSSIPSUB_PROTOCOL_ID`

Check failure on line 22 in misc/metrics/src/identify.rs

View workflow job for this annotation

GitHub Actions / Check rustdoc intra-doc links 

unresolved import `libp2p_gossipsub::GOSSIPSUB_PROTOCOL_ID`

Check failure on line 22 in misc/metrics/src/identify.rs

View workflow job for this annotation

GitHub Actions / Compile with MSRV 

unresolved import `libp2p_gossipsub::GOSSIPSUB_PROTOCOL_ID`

Check failure on line 22 in misc/metrics/src/identify.rs

View workflow job for this annotation

GitHub Actions / clippy (1.83.0) 

unresolved import `libp2p_gossipsub::GOSSIPSUB_PROTOCOL_ID`

Check failure on line 22 in misc/metrics/src/identify.rs

View workflow job for this annotation

GitHub Actions / clippy (beta) 

unresolved import `libp2p_gossipsub::GOSSIPSUB_PROTOCOL_ID`

Check failure on line 22 in misc/metrics/src/identify.rs

View workflow job for this annotation

GitHub Actions / Test libp2p 

unresolved import `libp2p_gossipsub::GOSSIPSUB_PROTOCOL_ID`

Check failure on line 22 in misc/metrics/src/identify.rs

View workflow job for this annotation

GitHub Actions / Test libp2p-metrics 

unresolved import `libp2p_gossipsub::GOSSIPSUB_PROTOCOL_ID`

use std::{
collections::HashMap,
sync::{Arc, Mutex},
Expand All @@ -37,9 +40,8 @@
const ALLOWED_PROTOCOLS: &[StreamProtocol] = &[
#[cfg(feature = "dcutr")]
libp2p_dcutr::PROTOCOL_NAME,
// #[cfg(feature = "gossipsub")]
// TODO: Add Gossipsub protocol name
libp2p_identify::PROTOCOL_NAME,
#[cfg(feature = "gossipsub")]
GOSSIPSUB_PROTOCOL_ID,

Check failure on line 44 in misc/metrics/src/identify.rs

View workflow job for this annotation

GitHub Actions / Check rustdoc intra-doc links 

failed to resolve: could not resolve path `GOSSIPSUB_PROTOCOL_ID`
libp2p_identify::PUSH_PROTOCOL_NAME,
#[cfg(feature = "kad")]
libp2p_kad::PROTOCOL_NAME,
Expand Down
Loading