Skip to content

fix: make wasm features implicit #6102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jul 16, 2025

Description

This PR tries to make wasm-bindgen features implicit

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@hanabi1224 hanabi1224 force-pushed the implicit-wasm-feature branch 3 times, most recently from 9893a50 to 5bf3e09 Compare July 16, 2025 14:21
@hanabi1224 hanabi1224 force-pushed the implicit-wasm-feature branch from 5bf3e09 to 97a5dd4 Compare July 16, 2025 14:22
@hanabi1224 hanabi1224 marked this pull request as ready for review July 16, 2025 14:42
@elenaf9
Copy link
Member

elenaf9 commented Jul 18, 2025

Thanks for the PR @hanabi1224.

I think this is a small improvement that would be nice to have. However, it is a breaking change in libp2p-swarm, which unfortunately requires us to also bump and release all libp2p protocols that depend on libp2p-swarm. This is overall quite painful and imo not worth it right now, especially because current users will already have enabled the wasm-bindgen feature.
I would delay this PR until the next required breaking change of libp2p-swarm.
cc @jxs

@dariusc93
Copy link
Member

Since we will delay this, I will move this to draft for now.

@dariusc93 dariusc93 marked this pull request as draft July 22, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants