fix: RELEASED_VERSION in bash script #6103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
force-pushed
the
fix-released-version-in-script
branch
from
c650e6d to
20aa231
Compare
|
Thanks @hanabi1224. The CI job is right now not executed on this PR because no package was modified. Can you do a quick test where you modify some file in a crate and see if the CI job runs correctly? |
|
@elenaf9 made some changes to |
Okay thanks, LGTM! Please revert the change again, then we can merge. |
hanabi1224
force-pushed
the
fix-released-version-in-script
branch
from
6bc97a1 to
20aa231
Compare
@elenaf9 Done. |
elenaf9
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the logic of retrieving
RELEASED_VERSIONinensure-version-bump-and-changelog.sh. The current logic breaks when a crate version is not tagged in the repo. e.g. in https://github.com/libp2p/rust-libp2p/actions/runs/16322151084/job/46102571787?pr=6102#step:13:35Notes & open questions
Change checklist