Initialize submission, add the start page. #1

illidanstormrange · 2025-08-20T07:27:01Z

初始化提交，增加起始页面。

This reverts commit b78bdad.

shlzxjp · 2025-08-20T08:53:43Z

CMakeLists.txt

+list(APPEND TGFX_INSPECTOR_LIBS Qt${QT_VERSION_MAJOR}::Core Qt${QT_VERSION_MAJOR}::Widgets
+        Qt${QT_VERSION_MAJOR}::WebSockets Qt${QT_VERSION_MAJOR}::OpenGL Qt${QT_VERSION_MAJOR}::Qml Qt${QT_VERSION_MAJOR}::Quick
+        Qt${QT_VERSION_MAJOR}::Network Qt${QT_VERSION_MAJOR}::QuickControls2 Qt${QT_VERSION_MAJOR}::Core5Compat)
+if (${QT_VERSION} VERSION_LESS "5.15")


统一升级到QT6吧，和PAG那边的工具保持一致

shlzxjp · 2025-08-20T08:59:40Z

src/ResolvService.h

+  std::atomic<bool> exit;
+  std::mutex mutex;
+  std::condition_variable conditionVariable;
+  std::vector<QueueItem> queue;
+  uint16_t port;
+  std::thread thread;


这些变量都初始化一下

shlzxjp · 2025-08-20T09:00:34Z

src/StartView.cpp

+#include "Socket.h"
+
+namespace inspector {
+ClientData::ClientData(int64_t time, uint32_t protoVer, int32_t activeTime, uint16_t port,


构造方法参数太多了，可以封装到结构体中

shlzxjp · 2025-08-20T09:04:01Z

src/StartView.cpp

+}
+
+QList<QObject*> StartView::getFileItems() const {
+  QList<QObject*> items;


构造的时候可以把初始容量传进去或者QList::reserve指定容量，避免append的过程中QList扩容

shlzxjp · 2025-08-20T09:08:58Z

src/StartView.h

+  std::string procName;
+  std::string address;
+  uint8_t type;


成员变量都初始化下

shlzxjp · 2025-08-20T09:09:14Z

src/StartView.h

+  QString filesPath;
+  QString filesName;
+  QDateTime lastOpened;


成员变量初始化

shlzxjp · 2025-08-20T09:09:40Z

src/StartView.h

+  QString lastOpenFile;
+  QStringList recentFiles;
+  QList<FileItem*> fileItems;
+  std::mutex resolvLock;


shlzxjp · 2025-08-20T09:10:15Z

vendor.json

+          "-DKDDockWidgets_QT6=ON",
+          "-DKDDockWidgets_STATIC=ON",
+          "-DKDDW_FRONTEND_QTQUICK=ON",
+          "-DCMAKE_PREFIX_PATH=\"/Users/lifengdy/Qt/6.8.1/macos/lib/cmake\""


这里写死了你的本地路径

shlzxjp · 2025-08-28T06:35:00Z

src/ResolvService.cpp

+#endif
+
+namespace inspector {
+ResolvService::ResolvService(uint16_t port) : port(port), thread([this] { worker(); }) {


worker()最好不要写在这里

shlzxjp · 2025-08-28T06:58:21Z

src/ResolvService.h

+  };
+
+ public:
+  ResolvService() = default;


默认构造可以不写，感觉这块应该禁用默认构造

shlzxjp · 2025-08-28T06:59:52Z

src/ResolvService.h

+  std::condition_variable conditionVariable = {};
+  std::vector<QueueItem> queue = {};
+  uint16_t port = 0;
+  std::thread thread;


看在构造函数中初始化，这里也可以使用std::shared_ptrstd::thread

shlzxjp · 2025-08-28T08:13:14Z

src/StartView.cpp

+}
+
+void StartView::loadRecentFiles() {
+  QSettings settings("MyCompany", "Inspector");


这个设置项叫MyCompany吗

shlzxjp · 2025-08-28T08:14:36Z

src/StartView.cpp

+    tgfx::debug::IpAddress addr;
+    size_t len = 0;
+    for (;;) {
+      auto msg = broadcastListen->readData(len, addr, 0);


readData返回的是data，变量取名为msg不太合适

这里读取的是broadcastMessage，我把命名补全

shlzxjp · 2025-08-28T08:21:59Z

src/ResolvService.cpp

+  thread.join();
+}
+
+void ResolvService::query(uint32_t ip, const std::function<void(std::string&&)>& callback) {


结合上下文看了下，std::function<void(std::string&&)中使用const char*应该就可以了，没必要使用右值引用

shlzxjp · 2025-08-28T08:22:39Z

src/StartView.cpp

+      tgfx::debug::BroadcastMessage bm = {};
+      memcpy(&bm, msg, len);
+      auto protoVer = bm.protocolVersion;
+      char procname[tgfx::debug::WelcomeMessageProgramNameSize];


初始化下

shlzxjp · 2025-08-28T08:26:46Z

src/StartView.cpp

+#include "tgfx/core/Clock.h"
+
+namespace inspector {
+ClientData::ClientData(Data data) : data(std::move(data)) {


这里的ClientData和Data可以合并吗？两个都是表示一个Data数据结构

这个之前是说构造函数太多，封装到结构体中了

shlzxjp · 2025-08-28T08:27:26Z

src/StartView.h

+  }
+
+ private:
+  QString filesPath = {};


QString filesPath = "";

shlzxjp · 2025-09-02T02:48:20Z

src/ResolvService.cpp

+  for (;;) {
+    std::unique_lock<std::mutex> lock(mutex);
+    conditionVariable.wait(
+        lock, [this] { return !queue.empty() || exit.load(std::memory_order_relaxed); });


这里的代码已经加锁，可以不使用atomic变量

这个锁是为了保护队列，atomic变量是判断是否退出的

shlzxjp · 2025-09-02T03:09:17Z

src/StartView.cpp

+}
+
+void StartView::connectToClientByLayerInspector(QObject* object) {
+  auto client = dynamic_cast<ClientData*>(object);


把rtti关掉，使用static_cast转换

shlzxjp · 2025-09-02T03:18:14Z

src/StartView.cpp

+  resolv = std::make_unique<ResolvService>(port);
+  loadRecentFiles();
+
+  broadcastTimer = new QTimer(this);


起始页在后台的时候，可以暂停定时器

还没做后台的功能，后面合入完善的功能后改下

Revert "Revert "Initialize submission, add the start page.""

1e9593a

This reverts commit b78bdad.

illidanstormrange requested a review from shlzxjp August 20, 2025 07:27

shlzxjp reviewed Aug 20, 2025

View reviewed changes

illidanstormrange added 4 commits August 20, 2025 17:40

Initializing variables; Qt is fixed to use Qt6.

a9c05b5

Initializing variables;

8592cab

Initializing variables;

ae98405

Initializing variables;

bbcdf67

shlzxjp reviewed Aug 28, 2025

View reviewed changes

Initializing variables;

8bde813

shlzxjp reviewed Sep 2, 2025

View reviewed changes

Disable rtti.

e3cce8b

Initialize submission, add the start page. #1

Are you sure you want to change the base?

Initialize submission, add the start page. #1

Uh oh!

Conversation

illidanstormrange commented Aug 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!