Skip to content

Conversation

Ant1r
Copy link
Contributor

@Ant1r Ant1r commented Jul 13, 2025

Even if the fix hasn't been merged yet into libpd's master branch, it appears that, since a PR has been sent to the libpd repo (libpd/libpd#410), the commit libpd/libpd@d7d1e1e is already available to amend our own libpd state.

So no need to wait :-)

@joebowbeer
Copy link
Contributor

joebowbeer commented Jul 13, 2025

Can you PR to my branch #147 ?

The build won't work without the changes I'm making in #147 (which of course include some of your changes)

I want to get a working build in CI before we merge

My branch pins ubuntu-22.04:

// ndkVersion must be one of those provided by the ubuntu-22.04 runner
// https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md
//
// Full list of NDK versions:
// https://developer.android.com/ndk/downloads

@Ant1r
Copy link
Contributor Author

Ant1r commented Jul 13, 2025

Actually I'm working on my side, and I now have a working state (currently on my fork master); the CI build obviously stops at publish stage, because I'm not authorized, but artifact is published in the github/actions.

I'm now building with a 27.2 ndk and recent tools.
I've found a working solution for the "externals" issues, like #127 and #75.

I'm not sure when I can work on this again, so I guess it's a good idea to make a PR with my working state, so you can cherry-pick as you wish (and hopefully we can have a working state as a basis!)

@Ant1r Ant1r changed the base branch from master to joebowbeer-patch-2 July 13, 2025 22:29
@joebowbeer
Copy link
Contributor

Can you demonstrate that your opensl_stream commit fixes the build issue of #147 ?

It would be great to get this build in CI working (#147) and the only thing blocking it AFAIK is opensl_stream

In this PR, the build failure is due to what I explained above

> NDK is not installed

@Ant1r
Copy link
Contributor Author

Ant1r commented Jul 13, 2025

Actually I can't target to your PR I think, only to a branch (here jeobowbeer-patch-2). So some commits seem missing...

OTOH my PR #150 builds!

@Ant1r
Copy link
Contributor Author

Ant1r commented Jul 29, 2025

libpd/libpd@d7d1e1e has been merged to libpd:master so this PR is obsolete.
Updating libpd submodule to libpd:master is enough.

@Ant1r Ant1r closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants