Release 3.1.3 #38
Merged
Release 3.1.3 #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a lot of folio/httpx logic piling up here that wasn't specifically related to ldlite. This was likely to increase over time with ECS and async support. I moved the authentication and query parameter code to a separate httpx-folio library which I then switched to with this PR. Coincidentally, there were some edge cases around sorting and paging that weren't well handled by LDLite and the intended behavior was never clear either. This became worse when I switched to id offset based paging with 3.1. Pulling the query parameter logic out allowed for more thorough testing and handling of these edge cases and LDLite should behave better for ad-hoc usage where queries are more likely to be sorted and subsets of data are more likely to be returned. I also accidentally exposed the new folio module in 3.1 when I intended for it to be internal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix for streaming SRS endpoints and a larger fix for complicated queries.