Skip to content

android: support Xiaomi rootless devices#663

Open
ousamabenyounes wants to merge 1 commit into
librepods-org:mainfrom
ousamabenyounes:fix/issue-658-xiaomi-rootless
Open

android: support Xiaomi rootless devices#663
ousamabenyounes wants to merge 1 commit into
librepods-org:mainfrom
ousamabenyounes:fix/issue-658-xiaomi-rootless

Conversation

@ousamabenyounes

Copy link
Copy Markdown

Summary

  • Add Xiaomi, POCO, and Redmi to the Android 16+ rootless support allowlist.
  • Extract rootless support checks into a pure predicate covered by unit tests.

Issues

Fix #658

Test verification (RED -> GREEN)

RED before implementation:

e: RootlessSupportTest.kt:28:20 Unresolved reference 'isRootlessSupported'.
e: RootlessSupportTest.kt:28:40 Unresolved reference 'ANDROID_16_SDK'.

GREEN with fix:

> Task :app:testFossDebugUnitTest
BUILD SUCCESSFUL

Revert proof:

RootlessSupportTest > android16XiaomiFamilyDevicesAreSupported FAILED
java.lang.AssertionError at RootlessSupportTest.kt:28
5 tests completed, 1 failed

Final checks:

./gradlew testFossDebugUnitTest --tests me.kavishdevar.librepods.utils.RootlessSupportTest
BUILD SUCCESSFUL

./gradlew assembleFossDebug
BUILD SUCCESSFUL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Request: Add Xiaomi POCO F6 Pro (Android 16 / Build BP2A)

1 participant