Skip to content

android: cap island width on tablets#664

Open
ousamabenyounes wants to merge 1 commit into
librepods-org:mainfrom
ousamabenyounes:fix/issue-657-tablet-island-width
Open

android: cap island width on tablets#664
ousamabenyounes wants to merge 1 commit into
librepods-org:mainfrom
ousamabenyounes:fix/issue-657-tablet-island-width

Conversation

@ousamabenyounes

Copy link
Copy Markdown

Summary

  • Cap the Dynamic Island overlay width on tablet-sized displays.
  • Keep phone behavior proportional while avoiding oversized tablet overlays.
  • Add a unit test for phone and tablet width calculations.

Issues

Fix #657

Test verification (RED -> GREEN)

RED before implementation:

e: IslandWindowTest.kt:27:47 Unresolved reference 'calculateIslandWindowWidth'.
e: IslandWindowTest.kt:32:48 Unresolved reference 'calculateIslandWindowWidth'.

GREEN with fix:

> Task :app:testFossDebugUnitTest
BUILD SUCCESSFUL

Revert proof:

IslandWindowTest > tabletWidthIsCapped FAILED
java.lang.AssertionError at IslandWindowTest.kt:32
2 tests completed, 1 failed

Final checks:

./gradlew testFossDebugUnitTest --tests me.kavishdevar.librepods.presentation.overlays.IslandWindowTest
BUILD SUCCESSFUL

./gradlew assembleFossDebug
BUILD SUCCESSFUL

@hanslauch325-eng

Copy link
Copy Markdown

Thank you very much could you please release or send me a version so I can test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tablet UI

2 participants