Mdns double add #309
Open
Mdns double add #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LWIP assertion clearly shows that calling mdns_resp_add_netif twice for the same interface is a no-no. So to prevent this we need to be able to easily check if this was already called. This PR adds a simple map that keeps track of the initialization state per each interface (identified via netif->num).
mkbit
reviewed
Aug 16, 2025
| { | ||
| stateIter = sNetIfState.insert(std::make_pair(netif->num, StateForNetIf::DISABLED)).first; | ||
| } | ||
| auto currentState = sNetIfState[netif->num]; |
Unfortunately my device still reboots due to an LWIP assert with the fix here. At the moment I can't connect a serial port to see the exact issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LWIP assertion clearly shows that calling mdns_resp_add_netif twice for the same interface is a no-no. So to prevent this we need to be able to easily check if this was already called.
This PR adds a simple map that keeps track of the initialization state per each interface (identified via netif->num). This should fix #306