check mobile sri in Challenge.isMine#20101
Merged
ornicar merged 3 commits intolichess-org:masterfrom Mar 27, 2026
Merged
Conversation
tom-anders
commented
Mar 26, 2026
app/controllers/Challenge.scala
Outdated
Contributor
Author
There was a problem hiding this comment.
@ornicar Can you also change this endpoint to AnonOrScoped? Claude gave me something that compiled and seemed to work, but I'm not comfortable enough yet in Scala to add it to the PR
c2d6906 to
ebc18b0
Compare
Collaborator
|
✔️ compiles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mobile app uses the following flow to create challenge links to send to other players:
/api/challenge/open/api/challenge/<id>/accept/api/challenge/<id>/showto get the full ID of the created gameWithout this change, if the challenge link was accepted as anonymous, in step 4) the endpoint would return the player ID of the user that accepted the challenge, not the one that created it, because
isMinewould incorrectly returnfalse. With this change,isMinecorrectly returnstruein this case and the app gets the correct ID, even if the challenge was created anonymously.