fix: sticky of claim button #428
Open
+1
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview stand statusStand was demolished |
Jeday
reviewed
Aug 10, 2024
DiRaiks
previously approved these changes
Aug 13, 2024
Jeday
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the claim button sticking (flashing) during scrolling.
Code review notes
The problem was due to changing the position of the block with the button in two ways, one after the other:
bottom: 0as default in styled-component (each rendering the page)It was solved: remove changing the position via DOM, and using pass position to styled-component
Testing notes
Check desktop and mobiles
Checklist: