Skip to content

fix(@clayui/css): LPD-63668 Deprecate and remove styles for paginatio… #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2025
Merged

fix(@clayui/css): LPD-63668 Deprecate and remove styles for paginatio… #6152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d958ba
fix(@clayui/css): LPD-63668 Deprecate and remove styles for paginatio…
pat270 Sep 2, 2025
6d7e2f8
chore(@clayui/pagination): LPD-63668 Deprecate size attribute
pat270 Sep 2, 2025
64fed57
chore(@clayui/pagination): Remove size example from storybook
pat270 Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/clay-css/src/scss/atlas/variables/_globals.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ $enable-caret: false !default;
$enable-deprecation-messages: true !default;
$enable-gradients: false !default;
$enable-grid-classes: true !default;
$enable-pagination-sizes: false !default;
$enable-pointer-cursor-for-buttons: true !default;
$enable-prefers-reduced-motion-media-query: true !default;
$enable-print-styles: true !default;
Expand Down
6 changes: 5 additions & 1 deletion packages/clay-css/src/scss/atlas/variables/_pagination.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,17 @@ $pagination-items-per-page-link: map-deep-merge(

$pagination-results-color: $pagination-color !default;

// Sizes
// @deprecated Pagination Sizes as of v3.146.0

// .pagination-sm

$pagination-link-border-radius-sm: 0.3125rem !default;
$pagination-font-size-sm: 0.75rem !default; // 12px
$pagination-item-height-sm: 1.5rem !default; // 24px
$pagination-padding-y-sm: 0 !default;

// .pagination-lg

$pagination-link-border-radius-lg: 0.3125rem !default; // 5px
$pagination-font-size-lg: 1.125rem !default; // 18px
$pagination-item-height-lg: 2.75rem !default; //44px
Expand Down
14 changes: 8 additions & 6 deletions packages/clay-css/src/scss/cadmin/components/_pagination.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,14 @@
@include clay-css($cadmin-pagination-results);
}

// Pagination Sizes
// @deprecated Pagination Sizes as of v3.146.0

.pagination-sm {
@include clay-pagination-variant($cadmin-pagination-sm);
}
@if ($cadmin-enable-pagination-sizes) {
.pagination-sm {
@include clay-pagination-variant($cadmin-pagination-sm);
}

.pagination-lg {
@include clay-pagination-variant($cadmin-pagination-lg);
.pagination-lg {
@include clay-pagination-variant($cadmin-pagination-lg);
}
}
11 changes: 6 additions & 5 deletions packages/clay-css/src/scss/cadmin/variables/_globals.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,18 @@ $cadmin-scaling-breakpoint-down: sm !default;
$cadmin-enable-clay-color-functions-process-fallback: true !default;

$cadmin-enable-caret: false !default;
$cadmin-enable-rounded: true !default;
$cadmin-enable-shadows: true !default;
$cadmin-enable-deprecation-messages: true !default;
$cadmin-enable-gradients: false !default;
$cadmin-enable-transitions: true !default;
$cadmin-enable-prefers-reduced-motion-media-query: true !default;
$cadmin-enable-grid-classes: true !default;
$cadmin-enable-pagination-sizes: false !default;
$cadmin-enable-pointer-cursor-for-buttons: true !default;
$cadmin-enable-prefers-reduced-motion-media-query: true !default;
$cadmin-enable-print-styles: true !default;
$cadmin-enable-responsive-font-sizes: false !default;
$cadmin-enable-rounded: true !default;
$cadmin-enable-shadows: true !default;
$cadmin-enable-transitions: true !default;
$cadmin-enable-validation-icons: false !default;
$cadmin-enable-deprecation-messages: true !default;

// Deprecated, no longer affects any compiled CSS

Expand Down
2 changes: 2 additions & 0 deletions packages/clay-css/src/scss/cadmin/variables/_pagination.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,8 @@ $cadmin-pagination-results: map-deep-merge(
$cadmin-pagination-results
);

// @deprecated Pagination Sizes as of v3.146.0

// .pagination-sm

$cadmin-pagination-font-size-sm: 12px !default; // 12px
Expand Down
14 changes: 8 additions & 6 deletions packages/clay-css/src/scss/components/_pagination.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,14 @@
@include clay-css($pagination-results);
}

// Pagination Sizes
/// @deprecated Pagination Sizes as of v3.146.0

.pagination-sm {
@include clay-pagination-variant($pagination-sm);
}
@if ($enable-pagination-sizes) {
.pagination-sm {
@include clay-pagination-variant($pagination-sm);
}

.pagination-lg {
@include clay-pagination-variant($pagination-lg);
.pagination-lg {
@include clay-pagination-variant($pagination-lg);
}
}
11 changes: 6 additions & 5 deletions packages/clay-css/src/scss/variables/_globals.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,18 @@ $scaling-breakpoint-down: sm !default;
$enable-clay-color-functions-process-fallback: false !default;

$enable-caret: false !default;
$enable-rounded: true !default;
$enable-shadows: false !default;
$enable-deprecation-messages: true !default;
$enable-gradients: false !default;
$enable-transitions: true !default;
$enable-prefers-reduced-motion-media-query: true !default;
$enable-grid-classes: true !default;
$enable-pagination-sizes: false !default;
$enable-pointer-cursor-for-buttons: true !default;
$enable-prefers-reduced-motion-media-query: true !default;
$enable-print-styles: true !default;
$enable-responsive-font-sizes: false !default;
$enable-rounded: true !default;
$enable-shadows: false !default;
$enable-transitions: true !default;
$enable-validation-icons: false !default;
$enable-deprecation-messages: true !default;

// Deprecated, no longer affects any compiled CSS

Expand Down
2 changes: 2 additions & 0 deletions packages/clay-css/src/scss/variables/_pagination.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,8 @@ $pagination-results: map-merge(
$pagination-results
);

/// @deprecated Pagination Sizes as of v3.146.0

// .pagination-sm

$pagination-font-size-sm: $font-size-sm !default;
Expand Down
1 change: 1 addition & 0 deletions packages/clay-pagination/src/Pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {Item} from './Item';
interface IProps extends React.HTMLAttributes<HTMLUListElement> {
/**
* The size of pagination element.
* @deprecated since v3.146.0 with no replacement.
*/
size?: 'lg' | 'sm';
}
Expand Down
38 changes: 0 additions & 38 deletions packages/clay-pagination/stories/Pagination.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
* SPDX-License-Identifier: BSD-3-Clause
*/

import {number} from '@storybook/addon-knobs';
import React from 'react';

import ClayPagination, {ClayPaginationWithBasicItems} from '../src';
Expand Down Expand Up @@ -54,43 +53,6 @@ NoHref.args = {
totalPages: 25,
};

export const Sizes = () => (
<>
<ClayPaginationWithBasicItems
defaultActive={number('Active Page', 8)}
ellipsisBuffer={number('Ellipsis Buffer', 2)}
ellipsisProps={{
'aria-label': 'More {0} through {1}',
title: 'More {0} through {1}',
}}
hrefConstructor={(page) => `#${page}`}
size="sm"
totalPages={25}
/>
<ClayPaginationWithBasicItems
defaultActive={number('Active Page', 8)}
ellipsisBuffer={number('Ellipsis Buffer', 2)}
ellipsisProps={{
'aria-label': 'More {0} through {1}',
title: 'More {0} through {1}',
}}
hrefConstructor={(page) => `#${page}`}
totalPages={25}
/>
<ClayPaginationWithBasicItems
defaultActive={number('Active Page', 8)}
ellipsisBuffer={number('Ellipsis Buffer', 2)}
ellipsisProps={{
'aria-label': 'More {0} through {1}',
title: 'More {0} through {1}',
}}
hrefConstructor={(page) => `#${page}`}
size="lg"
totalPages={25}
/>
</>
);

export const DisabledPages = () => (
<ClayPaginationWithBasicItems
defaultActive={8}
Expand Down
Loading