Skip to content

[EMB-381] add CI check for duplicate dependency resolutions #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinzenzLIFI wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[EMB-381] add CI check for duplicate dependency resolutions #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1fc951
chore(ci): add CI check for duplicate dependency resolutions
vinzenzLIFI May 19, 2026
72c757f
fix(ci): script ran on all changes instead of only pnpm lock
vinzenzLIFI Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/check-deduped-deps.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Check deduped deps

on:
pull_request:
branches:
- main

@effie-ms effie-ms May 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will need to run it only on lock file changes:

     paths:
        - 'pnpm-lock.yaml'

@effie-ms effie-ms May 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And possibly on the script changes: 'scripts/check-deduped-deps.js'

paths:
- 'pnpm-lock.yaml'
- 'scripts/check-deduped-deps.js'

jobs:
check-deduped-deps:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: Install dependencies
uses: ./.github/actions/pnpm-install
- name: Check for duplicate resolutions
run: pnpm check:deduped-deps
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"check:write:unsafe": "biome check --write --unsafe",
"check:types": "pnpm -r --parallel check:types",
"check:circular-deps": "pnpm -r --parallel check:circular-deps",
"check:deduped-deps": "node scripts/check-deduped-deps.js",
"link:bigmi": "node scripts/linkBigmi.js link && pnpm install",
"unlink:bigmi": "node scripts/linkBigmi.js unlink && pnpm install",
"link:sdk": "node scripts/linkSdk.js link && pnpm install",
Expand Down
Loading