Skip to content

chore: update rusqlite to 0.37.0 #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dpc
Copy link

@dpc dpc commented Aug 21, 2025

Update rusqlite.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Aug 21, 2025

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

@dpc dpc marked this pull request as ready for review August 21, 2025 21:36
@ldk-reviews-bot ldk-reviews-bot requested a review from tnull August 21, 2025 21:36
@dpc
Copy link
Author

dpc commented Aug 21, 2025

No idea if there are any MSRV, or other considerations. Just wanted to see if it will work and how hard it will be.

@tnull
Copy link
Collaborator

tnull commented Aug 22, 2025

No idea if there are any MSRV, or other considerations. Just wanted to see if it will work and how hard it will be.

It's mostly the same considerations as on #400, although we relaxed MSRV since: given that mismatching rusqlite versions in different crates render them completely incompatible, bumping rusqlite is an effort that needs to be coordinated across ~most/adjacent crates in the ecosystem. That means, at least check in with BDK, Cashu, Payjoin, and make sure everybody has a patch and realease ready short term, as otherwise users might get into a hairy situation if they're forced for other reasons to upgrade while other dependencies don't have a rusqlite-bumped release ready.

On top of that, note that due to the ensuing breakage, bumping rusqlite needs to ship as part of a major release (or minor pre-1.0) to follow SemVer rules. In some cases (BDK, for example) the next such release could be months away, making coordination across the 'rusqlite cabal' (to quote Calle) all the more necessary.

For reference, also see this recent PR bitcoindevkit/bdk#2002 on the BDK side which proposed to bump to yet-another-incompatible version.

TLDR: We should of course eventually bump the dependencies, but it requires more inter-crate coordiantion first.

@tnull tnull removed their request for review August 22, 2025 07:24
@dpc
Copy link
Author

dpc commented Aug 22, 2025

Oh. I forgot about #440. No worries, closing for now, will stay as a reference.

@dpc dpc closed this Aug 22, 2025
@dpc
Copy link
Author

dpc commented Aug 22, 2025

I'll try barking at a different tree: rusqlite/rusqlite#1727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants