-
Notifications
You must be signed in to change notification settings - Fork 2.2k
github: update goveralls tool #9348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
dbe17ef to
eaadfac
Compare
97c8bcd to
07a1bc0
Compare
guggero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
ellemouton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Perhaps a good idea to link to the PR you are referencing in the commit message?
The goverall tool had a bug regarding the module versioning of golang packages see also mattn/goveralls#222 for more background. Goveralls is wrapped by another library to make it available for github actions. So the relevant PR which is referenced here in LND is: shogo82148/actions-goveralls#521.
07a1bc0 to
c6bdbbe
Compare
|
Added the relevant PRs, thanks all for the review. |
Update goveralls tools to support golang module versioning.
The goverall tool had a bug regarding the module versioning of
golang packages see also
mattn/goveralls#222 for more background.
Goveralls is wrapped by another library to make it available for
github actions. So the relevant PR which is referenced here in
LND is:
shogo82148/actions-goveralls#521.