Key id must match in all circumstances #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
jwks()function inProviderController.phpwould return a default kid value if the$crypt->kidvalue was null. This could be seen in the output of.well-known/jwks.jsonwhich would return{"keys": [{"alg":"RS256","kty":"RSA","use":"sig","kid":1,"n":"abced..." }]}This had two problems. Firstly, the
kidneeds a string value, not a numeric. Secondly, the user token issued by thePOST/oauth/tokenroute would have akidvalue ofnull. Therefore, no clients could match the key needed to decode the JWT.This fix allows for the
kidto be set via theKeyRepositorymethods if necessary, and by default sets a default stringkidvalue for the returnedCryptKeyobject.