-
Notifications
You must be signed in to change notification settings - Fork 38
Search msg in a chat #2651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Search msg in a chat #2651
Conversation
| return getTextField().$(IconButton); | ||
| } | ||
|
|
||
| Future<List<TwakeListItemRobot>> getListOfChatSeach() async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Future<List<TwakeListItemRobot>> getListOfChatSeach() async { | |
| Future<List<TwakeListItemRobot>> getListOfChatSearch() async { |
Typo?
| test: ($) async { | ||
| //open chat and make some messages | ||
| final receiveMessage = (await prepareTwoMessages($)).$2; | ||
| final searchPharse = receiveMessage.substring(receiveMessage.indexOf("sent"), receiveMessage.length); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pharse ? Is it english?
| await ChatGroupDetailRobot($).getSearchIcon().tap(); | ||
| await $.waitUntilVisible($(AppBar).$(TextField)); | ||
| await $(AppBar).$(TextField).enterText(searchText); | ||
| // await SearchRobot($).enterSearchText(searchText); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why keep this commente code?
| // await SearchRobot($).enterSearchText(searchText); | ||
| await ChatGroupDetailRobot($).waitForEitherVisible($: $, first: $(TwakeListItem), second: $("No Results"), timeout: const Duration(seconds: 10)); | ||
| await Future.delayed(const Duration(seconds: 2)); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we at least have another search with at least one result, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not clear about your idea.
In this method, the result can contain one, more, or even zero items.
The code: await ChatGroupDetailRobot(
means that before performing the next action after entering a search, we will wait until we either see the label “No Results” or at least one item displayed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a step with search input bar, you wait until no result show, then you will make a search? Am I right? If I am right, the method name so confused
tddang-linagora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run this command before you commit your changes in integration_test directory:
dart format integration_test
| }, | ||
| ); | ||
|
|
||
| TestBase().runPatrolTest( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I want to run this test only, how can I do that?
|
When run multiple tests, the app isn't logged out between each test, so running the same set-up for every test, where there's login step, doesn't make sense, which also makes the following tests after the first test fail. |
Ticket
this ticket include code for "Search for messages inside a chat"
Resolved
Attach screenshots or videos demonstrating the changes
Screen.Recording.2025-11-03.at.15.11.34.mov