aes: add support for CCM and GCM algorithms #129
+186
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for two new AES algorithms: - TEE_ALG_AES_CCM - TEE_ALG_AES_GCM The user can now invoke: optee_example_aes <algo> Supported values for <algo> are: - TA_AES_ALGO_CCM - TA_AES_ALGO_GCM Signed-off-by: Amey Avinash Raghatate <[email protected]>
| op.params[1].tmpref.buffer = out_buf; | ||
| op.params[1].tmpref.size = *out_sz; | ||
|
|
||
| op.params[2].value.a = encrypt ? 1 : 0; |
There was a problem hiding this comment.
Is the ternary operator needed?
|
|
||
| op.params[2].value.a = encrypt ? 1 : 0; | ||
|
|
||
| op.params[3].tmpref.buffer = (void *)tag; |
There was a problem hiding this comment.
tag is already a void pointer.
| @@ -362,6 +368,99 @@ static TEE_Result cipher_buffer(void *session, uint32_t param_types, | |||
| params[1].memref.buffer, ¶ms[1].memref.size); | |||
| } | |||
|
|
|||
| static TEE_Result auth_aes_op(void *session, uint32_t param_types, TEE_Param params[4]) | |||
There was a problem hiding this comment.
Wouldn't auth_enc_op make more sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for two new AES algorithms:
The user can now invoke:
optee_example_aes
Supported values for are: