sign_verify: Add dynamic algorithm selection with sign and verify sup… #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
reviewed
Aug 22, 2025
There was a problem hiding this comment.
Hi @Akshay-Belsare, thanks for the PR.
This is a new application so please update the commit subject and description to state that fact. And, as mentioned below the detailed help text would be better in the usage() function.
…port Add new example for RSA PKCS PSS and V1_5 algorithms: - TEE_ALG_RSASSA_PKCS1_V1_5_SHA1 - TEE_ALG_RSASSA_PKCS1_V1_5_SHA224 - TEE_ALG_RSASSA_PKCS1_V1_5_SHA256 - TEE_ALG_RSASSA_PKCS1_V1_5_SHA384 - TEE_ALG_RSASSA_PKCS1_V1_5_SHA512 - TEE_ALG_RSASSA_PKCS1_PSS_MGF1_SHA1 - TEE_ALG_RSASSA_PKCS1_PSS_MGF1_SHA224 - TEE_ALG_RSASSA_PKCS1_PSS_MGF1_SHA256 - TEE_ALG_RSASSA_PKCS1_PSS_MGF1_SHA384 - TEE_ALG_RSASSA_PKCS1_PSS_MGF1_SHA512 Also add support to select algorithm at runtime. The user can now run the `optee_example_sign_verify <key_size> <algo name>` command, and the specified algorithm will be used during sign/verify. The user can now invoke: optee_example_sign_verify <key_size> <algo name> Supported values for <key_size> are: - 2048 bits - 3072 bits - 4096 bits Supported values for <algo name> are: - TA_ALG_PKCS1_V1_5_SHA1 - TA_ALG_PKCS1_V1_5_SHA224 - TA_ALG_PKCS1_V1_5_SHA256 - TA_ALG_PKCS1_V1_5_SHA384 - TA_ALG_PKCS1_V1_5_SHA512 - TA_ALG_PKCS1_PSS_MGF1_SHA1 - TA_ALG_PKCS1_PSS_MGF1_SHA224 - TA_ALG_PKCS1_PSS_MGF1_SHA256 - TA_ALG_PKCS1_PSS_MGF1_SHA384 - TA_ALG_PKCS1_PSS_MGF1_SHA512 If no algorithm is specified, TA_ALG_PKCS1_V1_5_SHA256 is selected by default. Based on the input, the corresponding algorithm and key size is selected and used for sign/verify operations. This enhancement improves flexibility by allowing users to test different RSA modes using a single binary. Signed-off-by: Amey Avinash Raghatate <[email protected]>
Address review comments for the new example Signed-off-by: Amey Avinash Raghatate <[email protected]>
Akshay-Belsare
force-pushed
the
amd_sign_verify
branch
from
b843a31 to
a658ee7
Compare
|
@jforissier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…port
Add support for new RSA PKCS PSS and V1_5 algorithms:
Also add support to select algorithm at runtime. The user can now run the
optee_example_sign_verify <key_size> <algo name>command, and the specified algorithm will be used during sign/verify.The user can now invoke:
optee_example_sign_verify <key_size>
Supported values for <key_size> are:
Supported values for are:
If no algorithm is specified, TA_ALG_PKCS1_V1_5_SHA256 is selected by default.
Based on the input, the corresponding algorithm and key size is selected and used for sign/verify operations. This enhancement improves flexibility by allowing users to test different RSA modes using a single binary.