feat: Make image loading customizable and remove Picasso dependency #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces an `ImageLoader` interface and `LineSdkImageConfig` to allow apps to provide their own image loading implementation. A `DefaultImageLoader` is provided as a basic, yet efficient, implementation with the following characteristics: - Caches bitmaps in memory using `LruCache` to reduce network requests and improve UI responsiveness. - Safely handles `ImageView` references within coroutines using `WeakReference` to prevent potential memory leaks. - Decodes image dimensions efficiently using `inJustDecodeBounds` before loading the full image into memory. The SDK no longer uses Picasso directly, and the dependency has been removed. Advanced image loading features can be implemented by creating a custom `ImageLoader` with libraries like Glide or Coil. Dialogs now use `LineSdkImageConfig.getImageLoader()` to load images.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces an
ImageLoaderinterface andLineSdkImageConfigto allow apps to provide their own image loading implementation.A
DefaultImageLoaderis provided as a basic, yet efficient, implementation with the following characteristics:LruCacheto reduce network requests and improve UI responsiveness.ImageViewreferences within coroutines usingWeakReferenceto prevent potential memory leaks.inJustDecodeBoundsbefore loading the full image into memory.The SDK no longer uses Picasso directly, and the dependency has been removed. Advanced image loading features can be implemented by creating a custom
ImageLoaderwith libraries like Glide or Coil.Dialogs now use
LineSdkImageConfig.getImageLoader()to load images.Fixes #163.