Add support for dsPIC33CH #2
Conversation
| /* send the 24-bit command */ | ||
| for (i = 0; i < 24; i++) | ||
| { | ||
| if ((cmd >> i) & 0x00000001) |
There was a problem hiding this comment.
If you plan to upstream your changes, I recommend splitting the reformatting into a separate PR as formatting changes can be slightly controversial. But if you're changing formatting, you might also want to put braces around single-statement blocks, as you already know this is usually a huge footgun. Just in case, I'd do this in a separate commit so it's easy to revert if the maintainer requests it.
There was a problem hiding this comment.
The goal was just to distill the diff between the dspic33f and dspicc33e implementations by eliminating formatting differences - I've yet to decide what I'm doing with it. On one hand, this is a quick, cheap way to be able to flash the dsPIC33CH from a Pi for primitive HIL purposes, so I wouldn't need to research / request a purchase of a x86/x64 SBC of some kind to run Microchip's junk but on the other hand it would be super-tightly coupled to vendor, platform, etc., so the possibility for much reuse is very low. I hadn't planned to upstream the changes and I'm probably just going to ditch this as not a good investment. Too many cons.
Uh oh!
There was an error while loading. Please reload this page.