Deprecate Mix::Clip and change the default blend mode
#144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
approved these changes
Sep 29, 2025
Comment on lines
+93
to
+94
| /// If you were using this with Vello, you should use the (new) `push_clip_layer` function instead. | ||
| #[deprecated(note = "Use `push_clip_layer` instead.", since = "0.5.0")] |
There was a problem hiding this comment.
Might want to mention that the other alternative is use Mix::Normal?
There was a problem hiding this comment.
I'm going to skip that because:
- If you were using this explicitly, then you definitely do want
push_clip_layer. - The docs for
push_clip_layeris the right place to explain the "child blend layers aren't properly supported" thing push_clip_layeris so much more performant, that pointing people towardsMix::Normalwhen they don't need it is a mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simpler version of #124, to get in before v0.5.0 (which is currently blocked on #134 anyway).