Add test for negative dash offset #1067
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
added
C-classic
|
Now linebender/kurbo#454 is merged, can we merge this one? |
|
The test is currently set for old kurbo, so it expects a panic. When we will have updated kurbo I will make this into regression test. |
Signed-off-by: sagudev <[email protected]>
tomcur
previously approved these changes
Jul 22, 2025
Signed-off-by: sagudev <[email protected]>
tomcur
reviewed
Jul 22, 2025
Comment on lines
+107
to
+113
| smoke_snapshot_test_sync(scene, ¶ms) | ||
| .unwrap() | ||
| .assert_mean_less_than(if cfg!(target_os = "macos") { | ||
| 0.005 | ||
| } else { | ||
| 0.001 | ||
| }); |
There was a problem hiding this comment.
Do you know why there is a difference between macOS and other systems here? Is it because of FastMath, or is it because macOS is tested on the GPU in CI?
There was a problem hiding this comment.
IDK, I do not own mac system to check this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repro for #1066