Skip to content

Improve tolerance calculation for stroke expansion #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve tolerance calculation for stroke expansion #1180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions sparse_strips/vello_common/src/flatten.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,14 @@ pub fn stroke(
line_buf: &mut Vec<Line>,
flatten_ctx: &mut FlattenCtx,
) {
// TODO: Temporary hack to ensure that strokes are scaled properly by the transform.
let tolerance = TOL / affine.as_coeffs()[0].abs().max(affine.as_coeffs()[3].abs());
// A transform can be decomposed to a rotation, a scale along the x and y axes, and another
// rotation. We are interested in knowing the max scale along those axes. This is the same as
// finding the semi-major axis of the ellipse created by transforming the unit circle.
let max_scale = kurbo::Ellipse::from_affine(affine)
.radii()
.to_size()
.max_side();
let tolerance = TOL / max_scale;

let expanded = expand_stroke(path, style, tolerance);
fill(level, &expanded, affine, line_buf, flatten_ctx);
Expand Down
Loading