Vello Classic: Draw "over" the base colour #1184
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
base_color
is used to initialise the backdrop, but if e.g. the backdrop were overwritten (such as by a destructive blend operation - see #1183), then it was possible to "punch through" the background, which effectively looked like drawing onto a transparent black layer.The biggest impact here is around transparency, as the default base colour normally ensures that no transparency reaches the render target, but with destructive layers, it is possible for it to. This means that detail in the alpha channel can be lost.
(I'm not completely sure what the right behaviour here is; this is open to discussion. Note that the old version of
base_color
can still be cheaply emulated, whereas emulating this behaviour requires adding a "dummy" layer around the entire scene)