Enforce matching dimensions between render context and pixmap when rasterizing #1193
Conversation
| let width = pixmap.width(); | ||
| let height = pixmap.height(); | ||
|
|
||
| if width != self.width || height != self.height { |
There was a problem hiding this comment.
Elsewhere, when invariants like this aren't obeyed, we typically panic:
https://github.com/linebender/vello/blob/main/sparse_strips%2Fvello_common%2Fsrc%2Fpixmap.rs#L43-L47
I'm wondering whether we should either return an Error or similarly panic (to at least be consistent).
There was a problem hiding this comment.
Good question, I’m not sure.
There was a problem hiding this comment.
I think the best option is allowing the consumer to decide what to do when they break an invariant (i.e. return an Error). Vello hybrid can return an Error type IIRC when spatiotemporal allocation suffers slot exhaustion.
Otherwise, I think it's fine to defer that to a larger review of this question and simply panic here (to be consistent with the rest of the system).
2 participants
Fixes #1191.