sparse_strips: Use peniko::Brush #1253
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <[email protected]>
sagudev
commented
Sep 29, 2025
| .map(|pixel| { | ||
| let rgba: [u8; 4] = match brush.image.format { | ||
| peniko::ImageFormat::Rgba8 => pixel.try_into().unwrap(), | ||
| peniko::ImageFormat::Bgra8 => [pixel[2], pixel[1], pixel[0], pixel[3]], |
There was a problem hiding this comment.
this stuff is still not handled
There was a problem hiding this comment.
I think we should just port unimplemented for now in renderer and then implement it in follow up rather than in this PR.
There was a problem hiding this comment.
Actually we only need to deal with image alpha (on sample I suppose). BGRA and premultiply are props of ImageData that vello_cpu does not use.
Signed-off-by: sagudev <[email protected]>
|
Thanks a lot, that looks reasonable to me. Assuming that we can get CI to pass, I would be fine merging the peniko change. |
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demo for linebender/peniko#134