Return all validation errors

[fenollp]

Closes #6

WIP:

• I'll do an Errors type that is a vector of Error as the encapsulation with prost_validate::Error rarely makes sense.
• Should that Vec be boxing errors?
• I'll split to a second trait when things start working

Any idea on what cargo invocation I can pull to show the final generated code? Looking inside ./target isn't helping. Thanks!

[Adphi]

Should that Vec be boxing errors?

I don't think that needs to be dynamic.

Any idea on what cargo invocation I can pull to show the final generated code?

I used cargo expand and a useless test to see the output:

prost-validate/prost-validate-derive-core/src/derive.rs

Lines 106 to 121 in 4ad7978

	mod tests {
	use super::*;
	#[test]
	fn tests() {
	let input = quote! {
	pub struct WrapperRequiredFloat {
	#[prost(message, optional, tag = "1")]
	#[validate(name = "tests.harness.cases.WrapperRequiredFloat.val")]
	#[validate(r#type(float(gt = 0.0)), message(required = true))]
	pub val: ::core::option::Option<::pbjson_types::FloatValue>,
	}
	};
	println!("{}", derive_2(input));
	}
	}

[Adphi]

Thank you very much 😀

Maybe we need to add the method in the example and update the README accordingly.

It also needs to be implemented in the prost-reflect-validatecrate.

[Adphi]

I think it would be better to return a Result instead of just a vector of errors. Using Result clearly indicates whether validation succeeded or failed and allows users to handle failures idiomatically with the ? operator. Also, returning an error type that implements From<Error> for tonic::Status makes integration with tonic seamless.