fixed_fused_linear_cross_entropy should pass through kwargs#832
Open
npuichigo wants to merge 8 commits intolinkedin:mainfrom
Open
fixed_fused_linear_cross_entropy should pass through kwargs#832npuichigo wants to merge 8 commits intolinkedin:mainfrom
npuichigo wants to merge 8 commits intolinkedin:mainfrom
Conversation
Collaborator
|
The reason why we don't want to pass kwargs is because |
Author
|
So maybe we should pass through ce_weight. |
Collaborator
|
Sure, it should be fine to pass through other arguments, such as |
|
Hello, I think, it is also necessary to add I'm hitting a compilation error with torch.compile. Basically: fixes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence