Fix #920: Check cross entropy monkey patch#927
Open
0xtoward wants to merge 1 commit intolinkedin:mainfrom
Open
Fix #920: Check cross entropy monkey patch#9270xtoward wants to merge 1 commit intolinkedin:mainfrom
0xtoward wants to merge 1 commit intolinkedin:mainfrom
Conversation
Collaborator
|
I'm thinking about just patching the forward method as flce does with some modifcitions in liger's loss_utils, so we only need to toggle an option to switch between flce and ce with functools.partial. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #920
Note: The test uses subprocess isolation because cross_entropy patches modify a global function (transformers.loss.loss_utils.nn.functional.cross_entropy). I'm wondering if there is an elegant way.
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence