[da-vinci] Add integration test: DVC reads survive SIT failure#2735
Open
sixpluszero wants to merge 2 commits intolinkedin:mainfrom
Open
[da-vinci] Add integration test: DVC reads survive SIT failure#2735sixpluszero wants to merge 2 commits intolinkedin:mainfrom
sixpluszero wants to merge 2 commits intolinkedin:mainfrom
Conversation
…e version Add testReadsFromLiveVersionSurviveSITFailure to DaVinciClientDiskFullTest to validate that Da Vinci client reads continue working after a StoreIngestionTask failure on the currently serving version. The test injects a task-level exception via setLastStoreIngestionException() after successful ingestion, then verifies all records remain readable. This works because VersionBackend partition futures are already completed successfully, so completePartitionExceptionally() is a no-op. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a new Da Vinci client integration test to ensure read availability is preserved even if the StoreIngestionTask for the currently serving version encounters a task-level failure after ingestion has already completed.
Changes:
- Introduce
testReadsFromLiveVersionSurviveSITFailureto validate reads remain successful after injecting aStoreIngestionTaskexception on the live version. - Add supporting imports to access DaVinci backend internals (
DaVinciBackend,VersionBackend,StoreIngestionTask,ReferenceCounted).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...-common/src/integrationTest/java/com/linkedin/venice/endToEnd/DaVinciClientDiskFullTest.java
Outdated
Show resolved
Hide resolved
...-common/src/integrationTest/java/com/linkedin/venice/endToEnd/DaVinciClientDiskFullTest.java
Show resolved
Hide resolved
- Assert sit.isRunning() before injecting the exception - Wait for !sit.isRunning() after injection to confirm the error path was fully exercised before checking reads - Add null guard on AvroGenericDaVinciClient.getBackend() - Move read assertions out of waitForNonDeterministicAssertion since they should pass deterministically after SIT stops Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testReadsFromLiveVersionSurviveSITFailuretoDaVinciClientDiskFullTestto validate that Da Vinci client reads are not affected when aStoreIngestionTaskfails on the currently serving version.setLastStoreIngestionException(). It confirms all records remain readable becauseVersionBackendpartition futures are already completed successfully, makingcompletePartitionExceptionally()a no-op.Test plan
DaVinciClientDiskFullTest.testReadsFromLiveVersionSurviveSITFailurepassesDaVinciClientDiskFullTest.testDaVinciDiskFullFailurestill passes (no regression)🤖 Generated with Claude Code