Add vpc dualstack capability #842
Open
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tarun Chinmai Sekar <[email protected]>
Signed-off-by: Tarun Chinmai Sekar <[email protected]>
tchinmai7
requested review from
Copilot,
ezilber-akamai and
jriddle-linode
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for VPC dual stack capability by adding a new constant to the regions capability definitions. This enables tracking and management of VPC dual stack features (IPv4 and IPv6) in the codebase.
Key Changes:
- Added
CapabilityVPCDualStackconstant for VPC dual stack functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ezilber-akamai
approved these changes
Nov 12, 2025
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
| SLAAC *InstanceIP `json:"slaac"` | ||
| Global []IPv6Range `json:"global"` | ||
| // NOTE: IPv6 VPCs may not currently be available to all users. | ||
| VPC []*VPCIP `json:"vpc"` |
Member
There was a problem hiding this comment.
Suggested change
| VPC []*VPCIP `json:"vpc"` | |
| VPC []VPCIP `json:"vpc"` |
Is []*VPCIP necessary here? Can we use a simpler type like []VPCIP?
Contributor
Author
There was a problem hiding this comment.
just using whatever ipv4 is doing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
Add vpc dualstack capability
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.