-
Notifications
You must be signed in to change notification settings - Fork 106
Support ACLP related fields in regions #2128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect | ||
sigs.k8s.io/yaml v1.3.0 // indirect | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: revert linodego replacement once the lindoego PR merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for ACLP (Alert Correlation and Lifecycle Platform) monitoring fields to the regions data sources in the Terraform provider. The changes enable users to query available monitoring services (alerts and metrics) for each Linode region.
- Adds
monitors
field to region data structures containing alerts and metrics lists - Updates parsing methods to accept context and handle diagnostics properly
- Includes comprehensive test coverage for the new monitoring functionality
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
linode/region/framework_models.go | Adds RegionMonitors struct and updates ParseRegion to handle monitors field |
linode/region/framework_datasource_schema.go | Defines schema for monitors attribute with alerts and metrics lists |
linode/region/framework_datasource.go | Updates to handle diagnostics from ParseRegion method |
linode/regions/framework_models.go | Updates parseRegions method signature to accept context |
linode/regions/framework_datasource.go | Passes context to parseRegions method call |
linode/region/framework_models_unit_test.go | Adds unit tests for monitors field parsing |
linode/regions/framework_models_unit_test.go | Adds unit tests for monitors field in regions collection |
linode/region/datasource_test.go | Adds acceptance tests for monitors attributes |
go.mod | Replaces linodego dependency with custom fork containing monitors support |
docs/data-sources/region.md | Documents monitors field and its attributes |
docs/data-sources/regions.md | Documents monitors field and its attributes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📝 Description
Support ACLP monitors related fields in regions.
✔️ How to Test
Unit and integration test
Manual Test