Allow to launch the joy launchfile #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Servin <[email protected]>
garyservin
force-pushed
the
add-joy-launch
branch
from
df68589 to
8c7cbc5
Compare
|
Hi Gary. Thank you for your pull request. I am a new maintainer on this project and your proposal looks worthwhile. Would you be willing to port it forward to the jazzy branch of linorobot2? I am doing a bunch of enhancements to the jazzy branch, aimed at bringing forward the hippo5329 fork features, and I'm not supporting humble. |
|
hi @PaulBouchier ! Sure, I'll forward port these fixes and close this PR. Thanks! |
|
Thanks Gary! Would you mind updating the README.md on the jazzy branch as well, so users know how to invoke this feature and what it does. I'm doing a lot of updating of docs at present because I believe they're important and valuable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing joy launch depending on the
joyargument as well as removes the unusedsensorsanddescriptionones that are launched from thedefault_robot.launch.py